vshn / signalilo

Forward alerts from Prometheus Alertmanager to Icinga2 via Webhooks

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[Feature Request] use SIGNALILO_ICINGA_HOSTNAME from label value

kubicgruenfeld opened this issue · comments

Hey, first, thanks for this great piece of software!

We would like to use one Signalilo deployment for a few hosts in Icinga2, currently we only could deploy one Signalilo for one Icinga2 host which is, in our case, not feasible since we have roundabout 3k hosts in Icinga2.

My idea would be to take the icinga2 host from a label value and configure the api-user filters accordingly.

Is this a feature you also would like to implement anyway? I would like to do it myself and come up with a PR, but i have no experience in go programming for now.

Hi, Thanks for reaching out!

For our internal use case, there is a one-to-one mapping from an OpenShift cluster Prometheus stack to a special Icinga2 host which only shows the Prometheus alerts for this particular cluster.

I think implementing this change should be fairly straightforward, even though there may be some spots in the code which assume that one Signalilo instance creates services on exactly one Icinga2 host.

A word of warning: while we'd happily review a PR, this is definitely not a use-case that has high priority for us internally, so it may be a while until we get around to trying to implement this change.