voxpupuli / puppet-zabbix

Puppet module for creating and maintaining zabbix components with puppet.

Home Page:https://forge.puppet.com/puppet/zabbix

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Refactoring test

Valantin opened this issue · comments

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: 7, 8
  • Ruby: 2.7, 3.x
  • Distribution: Archlinux and all other
  • Module version: 10.0.0

How to reproduce (e.g Puppet code you use)

Run acceptance on one of the operating system

What are you seeing

All Oses run a test with default version and N for the supported version
In most case it run twice with the some version, in other case like Archlinux run only with operating system repo version of package that not in the supported list.

What behaviour did you expect instead

Run acceptance test only one per version
Run acceptance only on supported version

Output log

https://archlinux.org/packages/extra/x86_64/zabbix-agent/
zabbix-agent 6.4.12-2

Any additional information you'd like to impart

Need a plan to use in the best way acceptance test, Probabli custom matrix not solve the problem, but run test on Archlinux with parameter zabbix_version 5 and 6 with the installed package as 6.4 isn't the best we can do

Continuing to check the test code I've see that it use a list of OS defined in spec instead using the metadata info

ok, it seems that the tests do not cover all operating systems, think this is the reason for the restricted OS list.

but probably miss a lot of stuff to realy support all OS