voxpupuli / puppet-zabbix

Puppet module for creating and maintaining zabbix components with puppet.

Home Page:https://forge.puppet.com/puppet/zabbix

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Apache module version 9 support

trenta opened this issue · comments

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: 7.21
  • Ruby: 2.7.0p0
  • Distribution: Debian
  • Module version: 9.2.0

How to reproduce (e.g Puppet code you use)

Run zabbix module 9.2.0 with apache module >= 9.0.0

What are you seeing

Apache module version 9.0.0 drops version 2.2 support and breaks version check

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Function Call, 'versioncmp' parameter 'a' expects a String value, got Undef (file: /etc/puppetlabs/code/environments/production/modules/zabbix/manifests/web.pp, line: 416, column: 8)

zabbix::web no longer needs

if versioncmp($apache::apache_version, '2.4') >= 0 {
      $directory_allow = { 'require' => 'all granted', }
      $directory_deny = { 'require' => 'all denied', }
} else {
      $directory_allow = { 'allow' => 'from all', 'order' => 'Allow,Deny', }
      $directory_deny = { 'deny' => 'from all', 'order' => 'Deny,Allow', }
}

The following should be sufficient.

$directory_allow = { 'require' => 'all granted', }
$directory_deny = { 'require' => 'all denied', }

That being said I haven't looked through the rest of the module to see if there are other places multiple apache versions are supported.

Hello, module version 9.2.0 doesn't support apache module >= 9.0.0.
But 8f8309d fixes this issue.

Thanks!