voxpupuli / puppet-nrpe

Puppet module for NRPE

Home Page:http://forge.puppetlabs.com/puppet/nrpe

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Adding interface for Hiera and nrpe resources

jehane opened this issue · comments

It would be useful to add nrpre ressources through hiera.
A pull request exist for pdcat/puppet-module-nrpe (
https://github.com/pdxcat/puppet-module-nrpe/pull/42 )

Is it possible to add this feature ?

Thanks

@jehane Seems reasonable, so I created #17.

Does that work for you?

(https://github.com/pdxcat/puppet-module-nrpe/pull/42 has some slightly odd implementation for plugins. I think the idea was you might want to be able to pass a template in for plugins. In practice, I'm not sure how well that would work. Would the variables you want to use in your template be in scope when created by the nrpe class? Not sure. Either way, I think I'd implement this by adding a template parameter to the nrpe::plugin class.)

It look great.

We want to add/modify commands in nrpe config files (changing parameters for checks, adding some new one, etc).
And on a second time, deploy scripts for specific checks (who are not available through deb or rpm).

And do all of it through hiera, of course

Thansk again