Consider adding the os::distro fact

Question

Consider adding the os::distro fact

chrisowensboston opened this issue 7 years ago · comments

Consider adding the os::distro fact. I run into puppet manifests that use codename to select templates, for example.

If you are interested I'll do this and submit a PR

Mickaël Canévet · Answer 1 · Tue Mar 14 2017 15:51:25 GMT+0800 (China Standard Time)

I don't understand this request. It looks like this fact is already present : https://github.com/camptocamp/facterdb/blob/master/facts/3.3/debian-8-x86_64.facts#L209-L220

chrisowensboston · Answer 2 · Wed Mar 15 2017 02:22:18 GMT+0800 (China Standard Time)

It is present for some OS and not for others. I noticed it missing for CentOS 6 and 7 and Redhat 6 and 7.

When I run Facter on a CentOS 6 machine, I get this:

os => {
  architecture => "x86_64",
  distro => {
    codename => "Final",
    description => "CentOS release 6.8 (Final)",
    id => "CentOS",
    release => {
      full => "6.8",
      major => "6",
      minor => "8"
    },
    specification => ":base-4.0-amd64:base-4.0-noarch:core-4.0-amd64:core-4.0-noarch:graphics-4.0-amd64:graphics-4.0-noarch:printing-4.0-amd64:printing-4.0-noarch"
  },
  family => "RedHat",
  hardware => "x86_64",
  name => "CentOS",
  release => {
    full => "6.8",
    major => "6",
    minor => "8"
  },
  selinux => {
    config_mode => "enforcing",
    current_mode => "enforcing",
    enabled => true,
    enforced => true,
    policy_version => "24"
  }
}

Mickaël Canévet · Answer 3 · Wed Mar 15 2017 03:32:50 GMT+0800 (China Standard Time)

Maybe this fact requires lsb-core which is not installed by default on RHEL.

chrisowensboston · Answer 4 · Wed Mar 15 2017 05:02:50 GMT+0800 (China Standard Time)

I will set up a fresh centOS 6 and check. Will take a day or so until I can do it Sent from handheld; pls excuse terseness...

…

-------- Original message -------- From: Mickaël Canévet <notifications@github.com> Date: 3/14/17 15:32 (GMT-05:00) To: camptocamp/facterdb <facterdb@noreply.github.com> Cc: chrisowensboston <ctag@chris-owens.com>, Author <author@noreply.github.com> Subject: Re: [camptocamp/facterdb] Consider adding the os::distro fact (#36) Maybe this fact requires lsb-core which is not installed by default on RHEL. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread. {"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/camptocamp/facterdb","title":"camptocamp/facterdb","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/camptocamp/facterdb"}},"updates":{"snippets":[{"icon":"PERSON","message":"@mcanevet in #36: Maybe this fact requires `lsb-core` which is not installed by default on RHEL."}],"action":{"name":"View Issue","url":"#36 (comment)"}}}

Kenyon Ralph · Answer 5 · Sat May 04 2019 09:58:59 GMT+0800 (China Standard Time)

Yes, the os.distro fact comes from lsb_release, so the package containing that program needs to be installed (redhat-lsb-core on Fedora and derivatives, lsb-release on Debian and derivatives).

Mickaël Canévet · Answer 6 · Sat May 04 2019 21:57:05 GMT+0800 (China Standard Time)

I think this project should not supports facts that are not available by default.
I think there are standard facts that could be used instead of os::distro.

Tim Sharpe · Answer 7 · Mon Jul 15 2019 10:34:44 GMT+0800 (China Standard Time)

I agree with @mcanevet that the facterdb factsets should represent the facts that are available on a system by default, otherwise they're not accurate representations.