Giters

voxpupuli / facterdb

A Database of OS facts provided by Facter

Home Page:http://voxpupuli.org/facterdb/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Include CentOS 8 stream facts

ekohl opened this issue · comments

commented

I'm looking at supporting CentOS 8 Stream but unsure how to identify this. The problem is that it also identifies as CentOS. The biggest difference is that it doesn't have a minor version:

{
  "os": {
    "architecture": "x86_64",
    "family": "RedHat",
    "hardware": "x86_64",
    "name": "CentOS",
    "release": {
      "full": "8",
      "major": "8"
    },
    "selinux": {
      "enabled": false
    }
  }
}

There are examples (puppetlabs/puppetlabs-postgresql#1222) which do regex matching and expect a minor version so I think it important that this can be tested.

commented

Having redhat-lsb-core package installed (providing lsb_release) facter would produce os.distro.id saying CentOSStream.

$ dnf install -y redhat-lsb-core

$ facter --version
3.14.20 (commit 28fd6cc7adae74c7748502e4d18d34f75be92f93)

$ facter -p os.distro
{
  codename => "n/a",
  description => "CentOS Stream release 8",
  id => "CentOSStream",
  release => {
    full => "8",
    major => "8"
  },
  specification => ":core-4.1-amd64:core-4.1-noarch"
}
commented

From facter 4.0.52 this is populated without having lsb_release, see puppetlabs/facter#2280

commented

IMHO we should not install additional packages because it may give the false impression that they're core facts. It'd be better to ensure we have facts with facter 4.0.52. Looking at https://github.com/voxpupuli/facterdb/tree/master/facts/4.0 we don't even have CentOS 8 facts. We do have https://github.com/voxpupuli/facterdb/blob/master/facts/4.2/centos-8-x86_64.facts but no stream facts.

In a few months CentOS Linux 8 will go End Of Life so I think it'll be safe to ignore the issue in this repo until then. After it's EOL we should re-record the facts for CentOS 8 and make them Stream facts. Thoughts?

commented

I agree with you, was mainly for posterity since this thread comes up high in Google search result to help others out. Making sure we have stream facts, using a later version of facter and bumping version abit higher seems like a preferred way to me.

commented

I updated #187. I'd be happy if we could merge that and then change the CentOS 8 box as well.

commented

By now CentOS Linux is EOL and I think we default to stream.