voxmedia / autotune

Platform for reusable news tools

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[question] Layout customization (Autotune is always prepended to body)

pardo-bsso opened this issue · comments

Hello again,

In https://github.com/voxmedia/autotune/blob/master/app/views/layouts/autotune/application.html.erb#L17 we have:

<%=render 'autotune/body_top' %>
<%= yield %>
<%=render 'autotune/body_bottom' %>

However in https://github.com/voxmedia/autotune/blob/master/appjs/app.js#L94

 $('body').prepend(view.$el);

And if we try to add content into body_top that would still move the application above it.
Is there any reason to not do something like

<%=render 'autotune/body_top' %>
<div id="autotune-main-body">
  <%= yield %>
</div>
<%=render 'autotune/body_bottom' %>
 $('#autotune-main-body').prepend(view.$el);

Thanks.

That sounds totally fine