vouch / vouch-proxy

an SSO and OAuth / OIDC login solution for Nginx using the auth_request module

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

transfer/fork vouch helm chart (Thank you Gavin for your years of support!!)

halkeye opened this issue Β· comments

πŸ‘‹ I think i'm shutting down my home k8s server and as such, kinda want to find owners for my helm charts. Are you willing to take it over? there's lots of github actions for publishing helm charts. Its been essentially no maintaince for a while now, but probably could get the version number updated more often.

Hi πŸ‘‹ , if no one else claims this @punkle and myself can keep an eye on it.

πŸ‘ Its not like i'd abandon ya'll, but i don't want to be the responsible maintainer for something I'm not actively using

https://github.com/halkeye-helm-charts/vouch/

Then something like https://helm.sh/docs/howto/chart_releaser_action/

That way vouch could also be a verified publisher on artifacthub.io

@halkeye thanks for holding down the VP helm chart these past years! I hope I'll get a chance to buy you a beverage in person next time I'm in Vancouver.

I myself am not an active k8s user and only have a smattering of skill with charts and chart maintenance and as such am (still) not in a position to support a helm chart.

@martina-if thank you for such a kind offer. If you and @punkle and your colleagues at roadie.io were able to support the VP helm chart that would be wonderful.

When folks have offered code to VP which includes a major feature addition or a new platform I've asked if they could commit to supporting the work "for at least two years". That seems like a reasonable ask for this as well. I'd hate to have to work through another transition sooner than that. How's that sound to you @martina-if?

I'd be happy to fork Gavin's repo to https://github.com/vouch/vouch-proxy-helm-charts or such and setup a gh team which has authority over that repo and include all of you on that.

I'd be happy to fork Gavin's repo to https://github.com/vouch/vouch-proxy-helm-charts or such and setup a gh team which has authority over that repo and include all of you on that.

typically I've seen the repo called "helm-charts" with a directory called charts.

ex https://github.com/jenkinsci/helm-charts/

@martina-if @punkle How's that all sound to you?

Yes that all sounds good. Would you like to setup the repo and we can take care of the rest or how would you like to take care of it?

Do you want to add me the org and I just transfer the repo? that will mean that if anyone comes to the repo (old link or something) it'll get auto redirected?

Otherwise ya'll can fork and I can update the readme.

Also, i'm looking into renovate to automate updates to my matrix helm charts, so I should be able to have that ready soon if you want to wait a day or two.

@punkle Thanks much! Very much appreciated.

Do you want to add me the org and I just transfer the repo? that will mean that if anyone comes to the repo (old link or something) it'll get auto redirected?

@halkeye oh yeah let's do that.

I'm distracted by a few other things atm but I'll put this at the top of the list next time I turn my attention to VP, probably early next week.

Hi @bnfinet, @halkeye , asking for 2 years of commitment is a very reasonable thing to do but we discussed this internally and we believe it wouldn't be fair to commit to more than 1 year since since we are a startup and things change quickly for us (including changing our architecture). What do you think about that?

We are also happy if someone else wants to take this and we help out sometimes.

Regarding the repo in https://github.com/vouch/vouch-proxy-helm-charts that sounds good to me.

@martina-if sure that's fine. Thanks for taking it on.

@halkeye @punkle @martina-if I've invited you all to to a new team helm-charts
https://github.com/orgs/vouch/teams/helm-charts/member

@halkeye do let me know if you need additional permissions or some other change in order to transfer the repo

https://github.com/vouch/vouch-helm-chart is moved over
(anyone in an org can transfer things into an org)
I had to rename it because I didn't want it to be called vouch/vouch
Its up to you now, permissions, nameing, etc

I'm working on a renovate.json for helm charts, but not having super luck yet, but I should have enough to open a bug with them now.

@halkeye thanks!

as per previous discussion I think next steps are to..

does that sound right?

And of course there's adjusting the README and any other references

move everything into charts/vouch-proxy similar to https://github.com/jenkinsci/helm-charts/

Assuming that's required for the github actions? I've never used them so can't say.

Probably worth submitting to https://artifacthub.io/ once the action is all setup

I have a bit of time this after noon so I am going to see what I can do around

  • renaming the repo
  • moving the code under the charts directory
  • and publish it to artifact hub

Ive started doing those bits: vouch/helm-charts#18, and #463

Working on the publish step.

I do not have the ability to rename the repo @bnfinet, would you mind taking care of the repo rename?

@punkle done!

https://github.com/vouch/helm-charts

Let me know if there's anything else I can help with.

@bnfinet there are a couple of other bits I will need.

  • The GitHub actions do not appear to be running on the helm-charts repo.
  • Would it be possible to configure GitHub pages on a branch called gh-pages on the helm-charts repo?
  • Also I am unsure if myself and Martina have the ability to merge changes to the repository.

@punkle see this comment WRT membership..
vouch/helm-charts#18 (comment)

I hope that resolves the access issues.

I was able to do everything I needed to do. Thanks @bnfinet

glad it worked @punkle

Thanks again!

@punkle @martina-if (and @halkeye too) I adjusted the portion of the README a few days back that links to vouch/helm-charts. (in #457)

https://github.com/vouch/vouch-proxy#kubernetes-nginx-ingress

If there's any change you'd like there (perhaps mentioning / linking to @RoadieHQ ??) please do feel free to adjust to your liking.

And same of course with the README for https://github.com/vouch/helm-charts

Please be sure to take the credit that you deserve!