cannot run with older node version (<=10)
nandiheath opened this issue · comments
Note: for support questions, please use stackoverflow. This repository's issues are reserved for feature requests and bug reports.
-
I'm submitting a ...
- bug report
- feature request
- support request => Please do not submit support request here, see note at the top of this template.
-
What is the current behavior?
Failed to build on node10 -
Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)
Probably this is because we are using string.matchAll which is a node12 function. We better find an alternative for this.
@nandiheath Gatsby requires Node.js 10.13.0 or higher
I think you may add a .nvmrc file to hint the node version, then add "using nvm" into the recommended practice in README somwhere. There is even a nvm for windows project that supports workflow similar to nvm (which supports Linux and Mac). So you may have all platforms covered. It's always nightmare-ish to use OS-bounded node version anyway.
yeah but what I mean is we shouldn't scarify the node 10 compatibility just because of a simple string.matchAll function, which we can easily replace with other implementation.
And I am not opposed to add .nvmrc and specify the version in README 😀
I'm revising README.md. I'll include the version in it.