const construct for ArcSwapOption

Question

const construct for ArcSwapOption

withoutboats opened this issue 3 years ago · comments

srrrse commented 3 years ago

It would be really nice if there were a const construct for ArcSwapOption.

Michal 'vorner' Vaner · Answer 1 · Thu Sep 16 2021 22:36:52 GMT+0800 (China Standard Time)

For the empty one? 🤔

I'll have to check that:

const fn is working all the way back to what the crate promises to support.
That the internal locking strategy is actually const-constructible.

But it might be possible

Michal 'vorner' Vaner · Answer 2 · Thu Sep 16 2021 23:49:30 GMT+0800 (China Standard Time)

It seems to work in #63. There's just the one thing I don't like: this needs to be a separate const_empty method instead of constifying the existing empty one. I'd be happy for some suggestions if this can be alleviated, or for a quick scan of the changes before I merge and publish it.

And thanks for the suggestion, it really does seem useful :-).

srrrse · Answer 3 · Fri Sep 17 2021 16:33:17 GMT+0800 (China Standard Time)

Yea, there's no way to make empty work since you can't call Default::default in a const context. Thanks for your quick attention to this :)

Michal 'vorner' Vaner · Answer 4 · Fri Sep 17 2021 18:01:06 GMT+0800 (China Standard Time)

Released as 1.4.0