`doMakeSameDomainsLinksRelative` somewhat counter-intuitive

[Martin Folkers]

What is this feature about (expected vs actual behaviour)?

While all options receive bool (which is intuitive, because their name suggests that you DO it or you DO NOT do it), doMakeSameDomainsLinksRelative receives an array while also being named do(...). This might lead to some confusion (plus TypeError).

I guess changing its name to something like makeSameDomainsLinksRelative could work, but ultimately, the desired array would be better off as global object $this->sameDomains (array) being set by setSameDomains (or whatever) containing the logic doMakeSameDomainsLinksRelative contains right now - so when 'activating' the option via doMakeSameDomainsLinksRelative, this would receive a bool.

How can I reproduce it?

Thinking about the naming convention - and eventually passing bool to function doMakeSameDomainsLinksRelative.

Does it take minutes, hours or days to fix?

Me: Hours
You: Seconds 😄

Any additional information?

It's rather the observation of a (tiny) inconsistency rather than a real problem, I totally get that, anyway I thought it's something to think about and make an informed decision 🦊