vmware-clarity / ng-clarity

Clarity Angular is a scalable, accessible, customizable, open-source design system built for Angular.

Home Page:https://clarity.design

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Row does not collapse if expanded row crosses table height (viewport) in Safari

ruchika0201 opened this issue · comments

Describe the bug

On Safari browser, a row once expanded using *clrIfExpanded , it does not collapse if the expanded row crosses the table height (viewport).
This works fine on Chrome browser.

How to reproduce

Stackblitz

Steps to reproduce the behaviour:

  1. On Safari browser, click on caret icon to expand the row.
  2. Click on caret icon again to collapse it.
  3. Notice the issue that the row is not getting collapsed.

Expected behavior

The row should get collapsed on Safari as well, as on Chrome.

Versions

Clarity version:

  • @clr/angular: 13.11.0
  • @clr/ui: 13.11.0

Framework version:

Angular 14

Device:

  • Type:Macbook
  • OS: iOS
  • Browser: Safari
  • Version: [e.g. 22]

Hi @ruchika0201,

I'm pleased to hear that the fix(removal of the implemented sizing override) I suggested is successfully addressing your use case. As we discussed, implementing overrides can lead to conflicts with the component's intended behavior, which is likely the cause of the reported issue. It's advisable to refrain from such overrides and rely on the component's native functionality.

We'll keep the issue open for another week to allow for any further discussion or clarification you may need. After that, we'll proceed with closing the issue. Looking forward to hearing from you.

Hi @ruchika0201,

We're closing this issue as discussed. If you encounter any further difficulties with the DataGrid (or) any other component, please feel free to open a new issue.

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.