diff subcommand should ignore gc tag
kgtw opened this issue · comments
Kris commented
We run the diff subcommand during CI process involved with PR reviews, which comments back the diff as a PR comment in github.
When this happens we are getting false/positives because in some cases the only difference is the gc tag.
"metadata": {
- "annotations": {
- "kubecfg.ksonnet.io/garbage-collect-tag": "my-service",
- },
- "labels": {
- "kubecfg.ksonnet.io/garbage-collect-tag": "my-service",
- },
Either the diff subcommand should ignore the gc tag entirely, or the option to provide it should be made available to avoid such instances of this happening.
Marko Mikulicic commented
which --diff-strategy
are you using?
Kris commented
diff --diff-strategy last-applied