Giters

vmware-archive / clarity

Clarity is a scalable, accessible, customizable, open source design system built with web components. Works with any JavaScript framework, built for enterprises, and designed to be inclusive.

Home Page:http://clarity.design

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

The detailButton of Clarity Datagrid Row is with wrong type in the datagrid-row.d.ts

TodorBonchev opened this issue · comments

commented

ClrDatagridRow has a public field detailButton which is of type ElementRef: https://github.com/vmware/clarity/blob/angular/projects/angular/src/data/datagrid/datagrid-row.ts#L173

But in the typings file: datagrid-row.d.ts the type of the field is HTMLButtonElement

Versions

Clarity project:

  • Clarity Core
  • Clarity Angular/UI

Clarity version:

  • v3.x
  • v4.x
  • v5.x

Framework:

  • Angular
  • React
  • Vue
  • Other:

Framework version:
Angular 11_

Device:

  • Type: [e.g. MacBook]
  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Additional notes

commented

Hi @TodorBonchev,

image

This is what I see in our dist folder.

I remember doing a PR about changing this from HTMLButtonElement to ElementRef around 3-4 months ago. Maybe the version you are using is older than the latest.

commented

Thanks Bogdan,
In this case you can close the issue if it is already fixed.

commented

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.