Unable to authorize if GitHub profile has no public email
medvednikovonelove opened this issue · comments
Currently you can only authorize on gitly if your GitHub profile has public email.
Steps to reproduce:
- Open your GitHub profile settings by clicking Settings menu in profile.
- Open "Profile" tab
- Choose "Select a verified email to display" in select labelled as "Public email"
- Try to authorize on gitly.org
Expected results:
You should authorize and your account name should be displayed in header.
Actual results:
Gitly just redirects you on index page, no account name displayed.
If you try to repeat all the steps above, but select your email instead:
In this case authorization is successful.
Possible solution
You should try to identify users with unique user id github API provides, not email, if this is possible.
Note
You can check if user has public email by visiting its profile page on GitHub. For users with public email it is displayed there.
At the very least, it would be good if gitly told you it couldn't register you because it couldn't find a public email - that way you at least know why it was sending you back to the index page.
Fixed.