vladmandic / automatic

SD.Next: Advanced Implementation of Stable Diffusion and other Diffusion-based generative image models

Home Page:https://github.com/vladmandic/automatic

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Request for ROCm 6.1 support on Linux

james-banks opened this issue · comments

In installer.py, the code which checks the rocm_ver has a comment explaining Pytorch does not have a release for ROCm 6.1, but this is no longer true.

Removing this condition from the if statement allows the rest of the script to install Torch for ROCm 6.1 automatically as expected already, so it's a very easy fix.

I didn't see any Pytorch nightlies offering support for ROCm 6.1.

I didn't see any Pytorch nightlies offering support for ROCm 6.1.

Check out the ROCm docs: https://rocm.docs.amd.com/projects/install-on-linux/en/develop/how-to/3rd-party/pytorch-install.html

pip3 install --pre torch torchvision torchaudio --index-url https://download.pytorch.org/whl/nightly/rocm6.1/

Oh, I wasn't aware of that, thanks.

i've added rocm 6.1 to installer in dev branch - note that its in nightly builds only, not yet in released builds.
also, in the future please create feature request using actual TEMPLATE and fill required fields - issues section is not for free-for-all-text.

i've added rocm 6.1 to installer in dev branch - note that its in nightly builds only, not yet in released builds.
also, in the future please create feature request using actual TEMPLATE and fill required fields - issues section is not for free-for-all-text.

Thank you for the quick response.

Appreciate and understand your point about templates - I was on mobile and didn't want to forget to make the request - but I will ensure I use them in the future.