vivid-planet / comet

Comet DXP

Home Page:https://comet-dxp.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Remove date-fns

fraxachun opened this issue · comments

Is it possible to remove it? Who would do it?

As we don't need it for formatting, there is nothing react-admin can do with it.

applications still can use date-fns if they need it.

I would suggest you remove it as part of the next release

At the moment it is used for formatting, but this should be refactored so that in future react-intl does the formatting?

date-fns has 2 components:

  • FormatLocalized: applications should switch to react-intl
  • LocaleContextProvider: used by FormatLocalized AND also provides a locale name (useLocaleName) which is used by Date*Picker to use the correct momentjs locale. This also h as to be converted to react-intl somehow

solved in #264