vitch / jScrollPane

Pretty, customisable, cross browser replacement scrollbars

Home Page:http://jscrollpane.kelvinluck.com/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Incorrect height of scrolling element after reinitialization.

alexeylepesin opened this issue · comments

elem.width(paneWidth);

Please move line 185 to 162

Please make more informative why I should do that or PR with more description

Hello.
I'm sorry, I had in mind the line 184 (pane.css ('width', '');) should be placed to line 162

pane.css('width', '');

In this case, the element will again have the same dimensions as before the initialization.

Is there possibility to make PR so I can see all needed actions and some test case?

Actually it's all ready done in line 156 and line 184 should be removed altogether.

Hello, sorry, I did not answer for a long time.

TEST CASE (tested on google chrome):
https://jsfiddle.net/0bmjz0zs/6/
1. click on "Run scroller"
  the width of the .jspPane element 356px
   table width 354px

2. delete one or more columns by clicking on the "Remove a column"

3. click on "Update scroller"
  the width of the .jspPane element has not changed and is still 356px
   table width after removing 1 column 284px, after removing 2 columns - 214px

The width of the .jspPane must match the width of the table.
I'm a bit inaccurate in describing the problem. I am using your library in my application twice: for the BODY element and for the container for TABLE. After manipulating TABLE and reinitializing both scrollers, the height of the BODY element has an incorrect height, although the cause is in the wrong width of the container for TABLE.

Thank you very much! excellent example. I take a look at this.

You are welcome.
I'm not strong in English, could you explain what the PR means?

Sorry it's PR is Pull Request.

Thanks

I have a simular issue with de height of the container when implementing live search when rows disappear! Any ideas on how to fix this?

As my time is limited you can audit that test case if it's the same as yours. If it's not you can submit small example how you example is different

Have new version made any progress on this?

Hello @vitch ,
I'm using your jsscrollpane, it is very useful to me. i struck in one place so please help me FIX IT.
i want table header fixed when scroll vertically and when i scroll horizontal it will be better work as normal scroller .
scr1

@RajuTicvic does commented fix your situation?

Which comments

This first one which @alexeylepesin tells you to change place in code or is your problem a new Issue?

@RajuTicvic Actually your request doesn't have anything to do with jScrollPane as it's purpose is only to 'skin' your scrollbars not alter how HTML tables work.