Percentage is now available by default

[Tomas Roos]

Lets move the logic in order to speed up parsing
facebook/react-native@3f49e74

[Vitaliy Potapov]

@ptomasroos thanks for sharing.
I think we should wait for RN 43 to get released and when make major release to let people keep using lib on earlier versions of RN.

[Paul Kamma]

Could it be currently used with the underscore syntax? Or are the values there precalculated too?

[Vitaliy Potapov]

@X-Tender could you show a demo what you mean?

[Paul Kamma]

Sorry I misunderstood the underscore elements. 😢 Vitaliy Potapov <[e-mail]> schrieb am Fr., 7. Apr. 2017, 15:00:

…

@X-Tender <https://github.com/X-Tender> could you show a demo what you mean? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#32 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABWTW5X7mppv3x94pc3mLV4KpDQEQ8rUks5rtjNvgaJpZM4MZWR9> .

[Vitaliy Potapov]

Never mind :)

[Joe McKie]

@vitalets it's worth noting that that commit is tagged 0.44, not 0.43 😄

[Vitaliy Potapov]

hi @joemckie thanks for info!
I seems RN team moved this feature from 43 to 44.

[Paul Kamma]

Mmmh no? real percent values are available in RN 0.43. Or waht do you mean? :)

I fooled a bit around and changed

tryCalcPercent(str) {
  if (percent.isPercent(str)) {
    return percent.calc(str, this.prop);
  }
  return null;
}

to:

tryCalcPercent(str) {
  if (percent.isPercent(str)) {
    return str;
  }
  return null;
}

in value.js and it worked out of the box. The question is just, change the % behavior there and make it maybe a breaking change or combine it with some kind of additional property.

[Cyrus Bowman]

+1 waiting for this.

[Vitaliy Potapov]

Will try to find time for that on the nearest weekend.
Btw, @X-Tender, is everything goes ok with your workaround?