visr / LasIO.jl

Julia package for reading and writing the LAS lidar format.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Rename "creation_doy" to "creation_dayofyear"

andyferris opened this issue · comments

I suspect this is a typo, and should be creation_day rather than creation_doy?

No this is not a typo, it stands for "day of year".

From the LAS 1.2 spec:

File Creation Day of Year: Day, expressed as an unsigned short, on which this file was created. Day is computed as the Greenwich Mean Time (GMT) day. January 1 is considered day 1.

File Creation Year: The year, expressed as a four digit number, in which the file was created.

Although arguably creation_day would still be a better name.

Haha, sorry didn’t realise that! creation_dayofyear?

I remember thinking exactly the same thing the first time I came across "doy" though I don't think it was in this library. +1 for changing it to creation_dayofyear.

I'm fine with changing it to creation_dayofyear. Can we deprecate the old field name somehow?

I guess we could via getproperty?

Yeah that should work