visit1985 / mdp

A command-line based markdown presentation tool.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Empty lines in code blocks not displayed correctly

dsyer opened this issue · comments

The fix for #96 made sure that empty lines in a code block are "coloured" (i.e. counted as part of the code), but the empty lines have a different line width than the non-empty lines, so it's still ugly.

lines-width

Do your empty lines have the same indentation?

Yes (none, because they are in a fenced block, maybe that's the bug?).

I can't reproduce this.

image

I test via rxvt-unicode (ncurses 6.0) on Arch Linux.
What's your setup?

I have a stock Ubuntu 14.04.

I have a workaround, which is to put a non-breaking space at the start of an empty line. It would be nice to not have to do that I guess.

I was able to reproduce it:
bug

The issue seams to be caused by commit 5125929, which was a fix for cygwin.
Have to double-check on Windows...

Fix looks good on cygwin.
@dsyer, can you cross-check in Ubuntu 14.04 please?

It's mostly OK. I think maybe there's a new problem though because a "long leader" in a code block sometimes still appears (on different lines than before, this time non-empty lines), they also sometimes remain on the screen after the slide has changed (and there is no code block):

image

You can make this go away by changing the font size with CTRL-(+/-).

I can't reproduce the list issue on Ubuntu 16.04. Can you provide your complete sample (maybe via pastebin.com)?