Regex capture groups not reflected in context parameters

Question

Regex capture groups not reflected in context parameters

mclotworthy opened this issue 5 years ago · comments

mclotworthy commented 5 years ago

Considering the route: /^\/inbox(?:\/?(actionable|other))?$/

A match will be made for URI: http://SomeMailServer/inbox

With expected context.params: { 0: undefined }

Currently pagejs returns an unexpected context.params of: { 0: "/inbox" }

mclotworthy · Answer 1 · Mon May 27 2019 11:07:51 GMT+0800 (China Standard Time)

In Route.prototype.match the loop starts from index 1 with the expectation that there will always be defined value for the first capture group. Suggest delete params[0] before beginning the loop that populates params.