visgl / loaders.gl

Loaders for big data visualization. Website:

Home Page:https://loaders.gl

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[Bug] deck.gl website can't import luma constants in loaders.gl

chrisgervang opened this issue · comments

I was testing loaders.gl v4 beta.5 on deck.gl's website and came across errors during the build pointing to:

import GL from '@luma.gl/constants';

Luma v9 doesn't export GL constants as the default export, so it throws export 'default' (imported as 'GL') was not found in '@luma.gl/constants' (possible exports: GL)

Should it be import {GL} from '@luma.gl/constants'?

Repro:

  1. master branch on deck.gl
  2. yarn bootstrap && cd website && yarn && yarn start

Good catch. loaders.gl should not depend on luma.gl.

The layers in the architecture are as follows, so loaders can import math and probe, but not luma or deck.

deck.gl < luma.gl < loaders.gl < math.gl / probe.gl