Test suite failure
snoyberg opened this issue · comments
I just got this failure from Stackage. Tests have been passing for a while now, so it might be a change in a dependency.
Unpacking to hit-0.4.3/
Resolving dependencies...
Configuring hit-0.4.3...
Building hit-0.4.3...
Preprocessing library hit-0.4.3...
[ 1 of 17] Compiling Data.Git.Internal ( Data/Git/Internal.hs, dist/build/Data/Git/Internal.o )
[ 2 of 17] Compiling Data.Git.Storage.CacheFile ( Data/Git/Storage/CacheFile.hs, dist/build/Data/Git/Storage/CacheFile.o )
[ 3 of 17] Compiling Data.Git.Storage.FileReader ( Data/Git/Storage/FileReader.hs, dist/build/Data/Git/Storage/FileReader.o )
[ 4 of 17] Compiling Data.Git.Delta ( Data/Git/Delta.hs, dist/build/Data/Git/Delta.o )
[ 5 of 17] Compiling Data.Git.Revision ( Data/Git/Revision.hs, dist/build/Data/Git/Revision.o )
[ 6 of 17] Compiling Data.Git.Ref ( Data/Git/Ref.hs, dist/build/Data/Git/Ref.o )
[ 7 of 17] Compiling Data.Git.Types ( Data/Git/Types.hs, dist/build/Data/Git/Types.o )
[ 8 of 17] Compiling Data.Git.Path ( Data/Git/Path.hs, dist/build/Data/Git/Path.o )
[ 9 of 17] Compiling Data.Git.Named ( Data/Git/Named.hs, dist/build/Data/Git/Named.o )
[10 of 17] Compiling Data.Git.Storage.PackIndex ( Data/Git/Storage/PackIndex.hs, dist/build/Data/Git/Storage/PackIndex.o )
[11 of 17] Compiling Data.Git.Storage.Object ( Data/Git/Storage/Object.hs, dist/build/Data/Git/Storage/Object.o )
[12 of 17] Compiling Data.Git.Storage.Pack ( Data/Git/Storage/Pack.hs, dist/build/Data/Git/Storage/Pack.o )
[13 of 17] Compiling Data.Git.Storage.FileWriter ( Data/Git/Storage/FileWriter.hs, dist/build/Data/Git/Storage/FileWriter.o )
[14 of 17] Compiling Data.Git.Storage.Loose ( Data/Git/Storage/Loose.hs, dist/build/Data/Git/Storage/Loose.o )
[15 of 17] Compiling Data.Git.Storage ( Data/Git/Storage.hs, dist/build/Data/Git/Storage.o )
[16 of 17] Compiling Data.Git.Repository ( Data/Git/Repository.hs, dist/build/Data/Git/Repository.o )
[17 of 17] Compiling Data.Git ( Data/Git.hs, dist/build/Data/Git.o )
In-place registering hit-0.4.3...
Preprocessing test suite 'test-repository' for hit-0.4.3...
[1 of 1] Compiling Main ( Tests/Repo.hs, dist/build/test-repository/test-repository-tmp/Main.o )
Linking dist/build/test-repository/test-repository ...
Preprocessing test suite 'test-unit' for hit-0.4.3...
[1 of 1] Compiling Main ( Tests/Tests.hs, dist/build/test-unit/test-unit-tmp/Main.o )
Linking dist/build/test-unit/test-unit ...
Running 2 test suites...
Test suite test-repository: RUNNING...
Test suite test-repository: PASS
Test suite logged to: dist/test/hit-0.4.3-test-repository.log
Test suite test-unit: RUNNING...
ref marshalling:
hexadecimal: [OK, passed 100 tests]
binary: [OK, passed 100 tests]
object marshalling:
unmarshall.marshall==id: [Failed]
*** Failed! (after 84 tests):
Exception:
not equal:
ObjCommit (Commit {commitTreeish = 869208302745e90bdf90a3b5f29445f9afec002b, commitParents = [e891e373941f57fe457bc01775ea0ba5adc04435,8a6c833dc48d98653098239b220614a481044f62], commitAuthor = Person {personName = "kc\\aol\DELHwNq\DELt|X^", personEmail = "_XMZNWwg`FoL]VQM", personTime = GitTime 32 600}, commitCommitter = Person {personName = "ghhLiapI\\xQkCX~G", personEmail = "jAho\\jBf}gt_IT`U", personTime = GitTime 33 600}, commitEncoding = Nothing, commitExtras = [CommitExtra {commitExtraKey = "aIG-eLS['W-2vFk6u5.dd_{1akldCIZvS(I@z!1JBsr0gHJQ$A+Uo*]Z>';P@PKu(C@ 47JDrNy]_P>z", commitExtraValue = "\b"},CommitExtra {commitExtraKey = "[83DWmE''{LP-~zsIY>_}|_Z0H#$..y*AqH'/boVXwu!B+7[L>]ys@HHBC0$;ozZti@y9>\\kkMkTS|=_", commitExtraValue = "\131"},CommitExtra {commitExtraKey = " #JOy}.DKdi=dI>H7iV6:B'_D|mosLIx*SY<pvzl]zf]i%BMsp>}(HlK(8GU/>|E9?+}@P@d4>Ie\DEL9\"\"", commitExtraValue = "\180"}], commitMessage = "\139"})
got: ObjCommit (Commit {commitTreeish = 869208302745e90bdf90a3b5f29445f9afec002b, commitParents = [e891e373941f57fe457bc01775ea0ba5adc04435,8a6c833dc48d98653098239b220614a481044f62], commitAuthor = Person {personName = "kc\\aol\DELHwNq\DELt|X^", personEmail = "_XMZNWwg`FoL]VQM", personTime = GitTime 32 600}, commitCommitter = Person {personName = "ghhLiapI\\xQkCX~G", personEmail = "jAho\\jBf}gt_IT`U", personTime = GitTime 33 600}, commitEncoding = Nothing, commitExtras = [CommitExtra {commitExtraKey = "aIG-eLS['W-2vFk6u5.dd_{1akldCIZvS(I@z!1JBsr0gHJQ$A+Uo*]Z>';P@PKu(C@ 47JDrNy]_P>z", commitExtraValue = "\b"},CommitExtra {commitExtraKey = "[83DWmE''{LP-~zsIY>_}|_Z0H#$..y*AqH'/boVXwu!B+7[L>]ys@HHBC0$;ozZti@y9>\\kkMkTS|=_", commitExtraValue = "\131\n#JOy}.DKdi=dI>H7iV6:B'_D|mosLIx*SY<pvzl]zf]i%BMsp>}(HlK(8GU/>|E9?+}@P@d4>Ie\DEL9\"\"\n\180"}], commitMessage = "\139"})
ObjCommit (Commit {commitTreeish = 869208302745e90bdf90a3b5f29445f9afec002b, commitParents = [e891e373941f57fe457bc01775ea0ba5adc04435,8a6c833dc48d98653098239b220614a481044f62], commitAuthor = Person {personName = "kc\\aol\DELHwNq\DELt|X^", personEmail = "_XMZNWwg`FoL]VQM", personTime = GitTime 32 600}, commitCommitter = Person {personName = "ghhLiapI\\xQkCX~G", personEmail = "jAho\\jBf}gt_IT`U", personTime = GitTime 33 600}, commitEncoding = Nothing, commitExtras = [CommitExtra {commitExtraKey = "aIG-eLS['W-2vFk6u5.dd_{1akldCIZvS(I@z!1JBsr0gHJQ$A+Uo*]Z>';P@PKu(C@ 47JDrNy]_P>z", commitExtraValue = "\b"},CommitExtra {commitExtraKey = "[83DWmE''{LP-~zsIY>_}|_Z0H#$..y*AqH'/boVXwu!B+7[L>]ys@HHBC0$;ozZti@y9>\\kkMkTS|=_", commitExtraValue = "\131"},CommitExtra {commitExtraKey = " #JOy}.DKdi=dI>H7iV6:B'_D|mosLIx*SY<pvzl]zf]i%BMsp>}(HlK(8GU/>|E9?+}@P@d4>Ie\DEL9\"\"", commitExtraValue = "\180"}], commitMessage = "\139"})
(used seed 7829374350396384261)
Properties Total
Passed 2 2
Failed 1 1
Total 3 3
Test suite test-unit: FAIL
Test suite logged to: dist/test/hit-0.4.3-test-unit.log
1 of 2 test suites (1 of 2 test cases) passed.
This is a false positive. The tests generate data that shouldn't be allowed in some fields, i need to tweak this properly.
OK. I've temporarily added hit to the "expected failures" list for Stackage. If you get the tests tweaked and want me to remove it from the list again, just ping me.
thanks ! it should be fixed now. in general do you prefer a fpco/stackage pull request or you're fine with just this notification ?
A comment like this is fine. I've updated Stackage to expect the test suite to pass, if there are problems I'll let you know. Thanks!