missing errno import

Question

ThomasWaldmann opened this issue 10 years ago · comments

see there:

TW · Answer 1 · Fri Oct 24 2014 22:13:17 GMT+0800 (China Standard Time)

BTW, could you license your code under a FOSS license, like MIT or BSD license?

Vincent Bernat · Answer 2 · Fri Oct 24 2014 23:42:39 GMT+0800 (China Standard Time)

Thanks for the notice. I also added an ISC license.

TW · Answer 3 · Sun Oct 26 2014 01:02:28 GMT+0800 (China Standard Time)

Thanks for licensing it freely. Just one remark: the license refers to "above copyright notice", but there is nothing above.

https://paste.thinkmo.de/Grd9uMnD <- btw, I modified/refactored the code a bit, just concentrating on ip detection.

Vincent Bernat · Answer 4 · Sun Oct 26 2014 01:34:45 GMT+0800 (China Standard Time)

❦ 25 octobre 2014 10:02 -0700, ThomasWaldmann notifications@github.com :

Thanks for licensing it freely. Just one remark: the license refers to
"above copyright notice", but there is nothing above.

Yes, I forgot to include the copyright notice. I have just corrected that.

Don't just echo the code with comments - make every comment count.
- The Elements of Programming Style (Kernighan & Plauger)