Bug with the Gtk4 Desktop icons NG Extension
Tuxman2 opened this issue · comments
Hello,
I'm not alone, there is a bug with the Gtk4 Desktop Icons NG extension and your theme. Especially when I install gtk4.0 theme in $HOME/.config/gtk-4.0 for libadwaita apps (see your install.sh --libadwaita command). My issue is that the Gnome desktop background image vanish and I have a white background. When the /.config/gtk-4.0 folder is empty, it's ok. But when your theme is installed in the /.config/gtk-4.0 folder, I've got this bug. So, it's a theme issue.
See what the author of the Gtk4 desktop icons extension NG say about it:
THEME ISSUES
Users have reported multiple issues with themes. This sheds light and clarifies the issues.
The extension has two parts, the extension itself that runs in the shell, and a pure Gtk4 program that runs outside the gnome shell and renders all the icons on the desktop. For example, when you see the preferences window, it is actually a libadwaita window spawned by the Gnome shell. The right click menus are true Gtk4 application menus and do not belong to the shell. Themes just applied to the shell will not apply to the application. In gnome tweaks, apply a them with the corresponding name to "Applications" or "Legacy Applications" as well. DING application window will respect that application theme. Most good, well designed, comprehensive themes have a dark application theme corresponding to the shell dark theme with the same name. This is true of most major distributions. The application and extension is regularly checked on default Ubuntu, Manjaro and by extension ArchLinux, and intermittently on the latest Fedora, and most themes works well.
If downloaded themes are applied, then they have to be designed for gtk4 as well, meaning they have to have correct .css files in a gtk4 folder. Older, gtk3 and gtk2 themes will not work on the app.
If a downloaded theme messes up the DING window, but works perfectly with the default distribution themes with no user themes applied, then there is a problem with the downloaded user themes. Downloaded user themes .css files take precedence over default system and application .css files and can create problems. Fixing application theme at this point will not help. In that case you can fix the .css file in the gtk4 folder of the theme or ask the Theme author for a fix.
If despite all the above you feel fixing the .css in the DING application or extension would help, please feel free to contribute a fix, see Contributing below, or create an issue with the suggestion for the fix.
Can you fix it ?
Thanks.
Regards.
I installed NG Extension but did not find this issue
Hi,
if you installed the Desktop Icons NG (DING) extension from rastersoft, there is no problem because that extension was made for GTK3. The 'GTK4 Desktop icons NG' extension is made for GTK4. When I enable the extension (Gnome tweaks) with your McMojave theme (with libawaita installed for your theme), my Gnome desktop background image vanish and I have a white background. Your ./install.sh --libadwaita command put some files in ./config/gtk-4.0 folder. As I said above, if this folder is empty, no problem. If this folder contains your files for libawaita, I have the bug. I have no problem with others gtk4 themes.
Regards.
The issue seems to be solved in the extension but I need to check it.