vinaysshenoy / mugen

Microlibrary for implementing infinite scroll on Android

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

example not working ....

amaydiam opened this issue · comments

I try to run example, but it;s not to load more ....

commented

@amaydiam I just ran the sample on an emulator with Android version 4.4.2
Sample is running fine. Please check with your device.

Note: Needs network to run the sample.

yes, network is ON
The first load , the data is received . But Load more function it's not work.
I ran on nexus 5 (Lolipop) and samsung Tab 3 (Kitkat).
like this :
https://vid.me/DkUy

@amaydiam We have identified the issue. The library requires enough items loaded on the first go to become scrollable, but it seems on high density screens, the number of items loaded is not. The issue is not with the library, but with the sample app. We will change the sample to load more items on high density screens.

I will also look into the library to allow configuring an automatic load if the first batch is not scrollable.

commented

@amaydiam Thank you notifying the issue. We have updated the sample to load items based on the screen height.

@vinaysshenoy Please review the PR
https://github.com/mipreamble/mugen/commit/ef371d284a8d1ac3196078a3c40d6d47f0d882cc

The sample will be available soon for you to test.

Fixed in 2d18149.