Missing package-lock.json
krokwen opened this issue · comments
Describe the bug
Due to missing package-lock.json I'm unable to build working app (building on linux).
Since the last release many things were changed in the nodejs world and no longer works...
Due to this i'm instantly getting an error about data download.
Also, locale lables are broken in the build app (but works with 'npm start')
So, please include package-lock.json. This file is aimed to allow other developers reproduce full original packages state.
To Reproduce
Steps to reproduce the behavior:
Just build and run app as described in readme.
- git checkout v1.2.1
- cd ExilenceNextApp
- npm i
- npm run smoke-build-linux
- cd dist
- ./appimage
- Now you don't see any localized labels in app
- You see the "error.title.get_prices_for_leagues" with 404 error
Expected behavior
Localization labels works
Price data downloads.
Screenshots
Version
latest release, v1.2.1
Additional context
Linux build. Fedora 37, Wayland, SELinux enabled.
Tried with node 14 and 16 (installed with nvm)
Also tried to run unpacked app (linux-unpacked/exilence-next-app)
somehow i missed that package-lock.json exists... but it was update 2yr ago, and keep updating on 'npm i'...