videolabs / libdsm

Defective SMb: A minimalist implementation of a client library for SMBv1 using Plain'Ol C

Home Page:http://videolabs.github.io/libdsm

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Build asn1 data in make dist

elthariel opened this issue · comments

As stated by @mstorsjo,

btw, if you are considering building release tarballs at some point, it might be nice to run the asn1Parse step as part of "make dist" - otherwise when crosscompiling (such as part of the vlc contrib system), you'd need to build libtasn1 twice, once for the host (to get the asn1Parse binary) and once for the actual target

I'm not very familiar with autotools, but I think this can be done via "dist-hook" somehow

One gotcha about this - asn1Parser produes C code that fits the current version of libtasn1. If you use a modern version of libtasn1 to produce the .c file (doing "make dist" on a modern system), you won't be able to build it with the slightly older versions of libtasn1 in e.g. debian stable. The only difference currently (between the 2.x and 3.x versions of libtasn1) is that you'd need to do s/asn1_static_node/ASN1_ARRAY_TYPE/ on the output c file.

We'll have to detect the version anyway at some point

On Thu, Jun 26, 2014 at 11:59 AM, Martin Storsjö notifications@github.com
wrote:

One gotcha about this - asn1Parser produes C code that fits the current
version of libtasn1. If you use a modern version of libtasn1 to produce the
.c file (doing "make dist" on a modern system), you won't be able to build
it with the slightly older versions of libtasn1 in e.g. debian stable. The
only difference currently (between the 2.x and 3.x versions of libtasn1) is
that you'd need to do s/asn1_static_node/ASN1_ARRAY_TYPE/ on the output c
file.


Reply to this email directly or view it on GitHub
#10 (comment).