No license header in minified bundle
joeyparrish opened this issue · comments
Hi everyone,
As you're probably aware, we're using mux.js in Shaka Player. When pushing Shaka Player releases through internal channels at Google, there are certain policy checks that happen, and mux.min.js always fails a check for a license header.
I know there's no reason you should have to comply with somebody else's policies, but would there be any objection to me sending a PR to insert your license header at the top of the minified bundles?
Thanks!
No problem at all. Maybe we can use a condensed version compared to what is in the unminified file?
The header in lib/index.js would add 126 bytes. If you want the header to be smaller, let me know in the PR and I'll make whatever changes you like. Thanks!
A slightly-condensed version using the SPDX-type header we use in Shaka Player is only 94 bytes. I'll upload the PR with that, and we can iterate from there.
That sounds fine. I was looking at the dist output https://unpkg.com/mux.js@5.6.2/dist/mux.js
where the license is this
/**
* mux.js
*
* Copyright (c) Brightcove
* Licensed Apache-2.0 https://github.com/videojs/mux.js/blob/master/LICENSE
*
* A stream-based aac to mp4 converter. This utility can be used to
* deliver mp4s to a SourceBuffer on platforms that support native
* Media Source Extensions.
*/
But just
/**
* mux.js
*
* Copyright (c) Brightcove
* Licensed Apache-2.0 https://github.com/videojs/mux.js/blob/master/LICENSE
*/
or similar would be fine.
Okay. I updated #343 with the text you suggested. Please take a look when you have time. Thanks!
Publish as 5.6.4. Thanks @joeyparrish.