Dataset.hidden property not reactive
dylan-george-field opened this issue · comments
I can only trigger the hidden property once from true > false (vice versa) using a ref.
The chart data is updating correctly.
See the modified demo attached to the shuffle button
https://codesandbox.io/s/demo-vue-chart-3-forked-318sq?file=/src/App.vue
@dylan-george-field Yeah it's strange because all the chartData object is reactive so it seems to be a Chart.js bug, I will look into this
Hey @victorgarciaesgi 👋
Thanks for creating this library, it's been a life saviour for us to migrate to Chart.js 3 on Vue 2.
Sadly, we also faced the same problem since we are using custom legends outside chart.js. We toggle the visibility of dataset using the hidden property and it is not reactive :(
Any chance you have some time to look into it ? 🙏
Also have problem with legend : true when onClick used custom function.
I think that answer in chartjs doc https://www.chartjs.org/docs/latest/configuration/legend.html
If options: { plugins: { legend: { onClick: newLegendClickHandler...
need to const defaultLegendClickHandler = Chart.defaults.plugins.legend.onClick;
So, default update chart can be trigered. Will that help on fixing issue?
Hi all! Sorry for the lack of updates i try to be present as possible. I didn't know why it didn't update, the watcher corretly triggers when hidden is modified so I though that was on Chart.js side
Great news guys, 3.0.5 released and I found the bug! :D
It was from me, it came from a piece of code I borrowed from vue-chartjs
af4d6b3#diff-af796a020e973df5f3ef424841c9f55fdb45d09ffac0ca4715fc0692f257b2e3R122
Amazing, thank you so much!!
Keep me updated! I'll wait for @dylan-george-field answer too before closing because I kind of abandonned him :(
Oh I just noticed that you only released it for 3.x, can you also make the 2.0.5 available so I can try it out in our Vue 2 app? :) @victorgarciaesgi
Oh yeah sorry, I will release it right now :)
Done!
Just tried it out, works perfectly now with 2.0.5.
Thanks once again and have a great evening! ✨
Wow, that was quick and assomme. Thank you so much!