Add back compatibility with Scala 2.11

Question

Add back compatibility with Scala 2.11

vickumar1981 opened this issue 4 years ago · comments

Vic Kumar commented 4 years ago

Spark EMR currently still uses the 2.11 compiler.

This commit: 7dfbb76 dropped support for 2.11.

Add back in compatibility with Scala 2.11

Vic Kumar · Answer 1 · Fri Jun 19 2020 11:46:15 GMT+0800 (China Standard Time)

Pushed 1.2.3-SNAPSHOT, available for Scala 2.11: https://oss.sonatype.org/content/repositories/snapshots/com/github/vickumar1981/stringdistance_2.11/1.2.3-SNAPSHOT/

Need to test that this works with Scala 2.11 and can merge into master.

Vic Kumar · Answer 2 · Fri Jun 19 2020 12:32:38 GMT+0800 (China Standard Time)

Addressed by #51.

Version 1.2.3 should be cross-compiled for Scala 2.11, 2.12, & 2.13.

Max Zhao · Answer 3 · Fri Jun 19 2020 23:43:17 GMT+0800 (China Standard Time)

Hi Vic, This is wonderful! I will give it a test from my side and let you know the testing result. Have wonderful weekends! Max

…

On Thu, Jun 18, 2020 at 11:46 PM Vic Kumar ***@***.***> wrote: Pushed a 1.2.3-SNAPSHOT that is available for Scala 2.11: https://oss.sonatype.org/content/repositories/snapshots/com/github/vickumar1981/stringdistance_2.11/1.2.3-SNAPSHOT/ Need to test that this works with Scala 2.11 and can merge into master. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#50 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABZ2USTX6UVDORJ4I35MOZ3RXLNRHANCNFSM4NY7MEKQ> .

Vic Kumar · Answer 4 · Mon Jun 29 2020 03:33:19 GMT+0800 (China Standard Time)

@mzhao577 Did the 1.2.3 version work for you with Scala 2.11?

Max Zhao · Answer 5 · Mon Jun 29 2020 09:44:16 GMT+0800 (China Standard Time)

Hi Vic, I just tested 1 case that I used most, the levenshstein distance and score. It looks great. I plan to run all the other tests listed in your GitHub testing cases. I am doing it now. I will get you updated once I got it ran. Max

…

On Sun, Jun 28, 2020 at 3:33 PM Vic Kumar ***@***.***> wrote: @mzhao577 <https://github.com/mzhao577> Did the 1.2.3 version work for you with Scala 2.11? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#50 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABZ2USTSIPV34OGZXP6DUE3RY6LIVANCNFSM4NY7MEKQ> .

Vic Kumar · Answer 6 · Mon Jun 29 2020 23:11:49 GMT+0800 (China Standard Time)

Thanks Max. If you do add any more algorithms, please feel free to PR the repo if you think they'd be useful to others. I'll probably be doing a few more updates in a couple of weeks - nothing heavy, just adding more documentation and maybe putting scalafmt to auto-format all the files. Appreciate it. Cheers. Vic Kumar vickumar@gmail.com

…

On Sun, Jun 28, 2020 at 9:44 PM Max Zhao ***@***.***> wrote: Hi Vic, I just tested 1 case that I used most, the levenshstein distance and score. It looks great. I plan to run all the other tests listed in your GitHub testing cases. I am doing it now. I will get you updated once I got it ran. Max On Sun, Jun 28, 2020 at 3:33 PM Vic Kumar ***@***.***> wrote: > @mzhao577 <https://github.com/mzhao577> Did the 1.2.3 version work for > you with Scala 2.11? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > < #50 (comment) >, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/ABZ2USTSIPV34OGZXP6DUE3RY6LIVANCNFSM4NY7MEKQ > > . > — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#50 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABTQHMA3LVWTICNW27RJIRLRY7WXZANCNFSM4NY7MEKQ> .

Max Zhao · Answer 7 · Tue Jun 30 2020 06:09:21 GMT+0800 (China Standard Time)

Hi Vic, I was busy recently. I will do more testing once I get more free time. Your code is very useful. Please keep it up! If there are things I can do to help. Please do not hesitate to reach out to me. Thanks for your wonderful work! Max

…

On Mon, Jun 29, 2020 at 11:12 AM Vic Kumar ***@***.***> wrote: Thanks Max. If you do add any more algorithms, please feel free to PR the repo if you think they'd be useful to others. I'll probably be doing a few more updates in a couple of weeks - nothing heavy, just adding more documentation and maybe putting scalafmt to auto-format all the files. Appreciate it. Cheers. Vic Kumar ***@***.*** On Sun, Jun 28, 2020 at 9:44 PM Max Zhao ***@***.***> wrote: > Hi Vic, > > I just tested 1 case that I used most, the levenshstein distance and > score. It looks great. > > I plan to run all the other tests listed in your GitHub testing cases. I > am doing it now. I will get you updated once I got it ran. > > Max > > > On Sun, Jun 28, 2020 at 3:33 PM Vic Kumar ***@***.***> > wrote: > > > @mzhao577 <https://github.com/mzhao577> Did the 1.2.3 version work for > > you with Scala 2.11? > > > > — > > You are receiving this because you were mentioned. > > Reply to this email directly, view it on GitHub > > < > #50 (comment) > >, > > or unsubscribe > > < > https://github.com/notifications/unsubscribe-auth/ABZ2USTSIPV34OGZXP6DUE3RY6LIVANCNFSM4NY7MEKQ > > > > . > > > > — > You are receiving this because you modified the open/close state. > Reply to this email directly, view it on GitHub > < #50 (comment) >, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/ABTQHMA3LVWTICNW27RJIRLRY7WXZANCNFSM4NY7MEKQ > > . > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#50 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABZ2USUZ4JEBFW7Q66TSLTTRZCVMLANCNFSM4NY7MEKQ> .