NewGenArgs arguments failing

[Halil Kaya]

Hi,

I guess after the latest changes, when I try to install ksops with the command below, I get the error.

$ go get -u github.com/viaduct-ai/kustomize-sops
...
# github.com/viaduct-ai/kustomize-sops
go/pkg/mod/github.com/viaduct-ai/kustomize-sops@v0.0.0-20200405180615-a3e1ac600551/ksops.go:102:32: too many arguments in call to types.NewGenArgs
	have (*types.GeneratorArgs, *types.GeneratorOptions)
	want (*types.GeneratorArgs)

I have also added a comment into the related commit:
61ce22f#r39118374

Thanks,
Halil

[Halil Kaya]

It might be caused by my Go version. Could you please also add the required Go version in README?

[Halil Kaya]

Yes, the problem is about the Go version. I was using 1.14. When I use 1.13, it still fails but it successes when specifying the branch go-1.13:

go get -u github.com/viaduct-ai/kustomize-sops@go-1.13

[Halil Kaya]

However, it still fails when installing with make: :(

$ make install
go build -buildmode plugin -o "ksops.so"
# github.com/viaduct-ai/kustomize-sops
./ksops.go:102:32: too many arguments in call to types.NewGenArgs
	have (*types.GeneratorArgs, *types.GeneratorOptions)
	want (*types.GeneratorArgs)
make: *** [build-plugin] Error 2```

[Devin Stein]

Hi @halilkaya !

Thanks for making an issue. I'm aware of this issue, we currently pin ksops to the latest kustomize, but the Go build for the latest kustomize version (v3.5.5) is broken.

I'll make a PR to pin make kustomize to install a compatible version (v3.5.4) while we wait on a response from the kustomize team

Related issues for tracking:

#28
kubernetes-sigs/kustomize#2462

[Halil Kaya]

Excellent! Thanks.

[Devin Stein]

@halilkaya master branch should be fixed now