viadee / vPAV

viadee Process Application Validator

Home Page:https://www.viadee.de/java/process-application-validator

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Question: Can vPAV identify issues ID'ed by bpmnlint?

Charles-Irvine opened this issue · comments

Can vPAV be made to identify the kind of problems described in the following bpmnlint webpge?

https://github.com/bpmn-io/bpmnlint/tree/master/docs/rules#rules

Hi @Charles-Irvine,

generally speaking, all kinds of such rules should be possible to be implemented. I‘ll look into it after my holidays and try to provide an example. We‘d be happy to have follow up PRs implementing the missing rules.

Best regards
Sascha

Thanks Sascha. For now, I'm just running bpmnlint from the command line and that works fine. However, one tool to do everything would be preferable. Plus, vPAV runs as a JUnit test which fits into our build stream better.

Hey @Charles-Irvine,
I added a new checker called LinterChecker. I already implemented an exemplary rule checking conditional flows.
You can check my respective commits starting at 2907402.

If you have any feedback, feel free to hit me up. Also, if you want to extend the functionality, we´re more than happy to welcome PRs.

Best regards
Sascha

Phenomenal! What do I need to specify in my POM file to pick up the latest? I'm not a solid maven guy.

<dependency>
  <groupId>de.viadee</groupId>  
  <artifactId>viadeeProcessApplicationValidator</artifactId>
  <version>3.0.7-SNAPSHOT</version>
  <scope>test</scope>
</dependency>

I'll have to publish the artifact to Maven central first, so this might take a day until its available.

Excellent! I'll update my pom tomorrow. Thanks

Looks like the release build is broken atm. Until it's fixed, you'll need to clone the repo and build it yourself. I hope I can fix it next week.

Best regards
Sascha

Ok. Thanks

I released a snapshot version just now, so it should be available soon!

I'll try it out right away. Thanks!

What is the version of the snapshot?

3.0.7-SNAPSHOT

I'm getting the error below when I try to build. Any ideas? Thanks, Charles

Failed to execute goal on project �[36mtesting-poc�[m: �[1;31mCould not resolve dependencies for project com.ntg.bpm:testing-poc:jar:0.0.1-SNAPSHOT: Failed to collect dependencies at de.viadee:viadeeProcessApplicationValidator:jar:3.0.7-SNAPSHOT�[m: Failed to read artifact descriptor for de.viadee:viadeeProcessApplicationValidator:jar:3.0.7-SNAPSHOT: Could not transfer artifact de.viadee:viadeeProcessApplicationValidator:pom:3.0.7-SNAPSHOT from/to central (http://repo1.maven.org/maven2): Failed to transfer http://repo1.maven.org/maven2/de/viadee/viadeeProcessApplicationValidator/3.0.7-SNAPSHOT/viadeeProcessApplicationValidator-3.0.7-SNAPSHOT.pom. Error code 501, HTTPS Required -> �[1m[Help 1]�[m

As the error indicates, you need to connect via HTTPS. Can you check your Maven settings and validate that you are indeed using HTTPS?

Interesting. I've never fiddled with that kind of setting before. I'll check. Wonder why the problem only effects retrieving the vpav snapshot?

Ok. Got that problem fixed. I needed to add a snapshot repo to my pom file. Sorry for the bother. Will try out the updates not. (Sorry, I will try out the updates now. )Thanks

Using the snapshot I get the error below, which seems like a bug. The class is defined and where it is supposed to be. I don't get the error with 3.0.6.

image

Let me know if you want me to create an issue.

As this is another issue, yes please. I´ll be closing this one. 👍