versatica / mediasoup

Cutting Edge WebRTC Video Conferencing

Home Page:https://mediasoup.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

set MS_LOG_DEV_LEVEL 3, lead to build errors

adcen0107 opened this issue · comments

Your environment

  • Operating system: ubuntu22.04
  • Node version:v18.19.1
  • npm version:10.2.4
  • gcc/clang version:gcc version 11.4.0
  • mediasoup version: 3.13.24
  • mediasoup-client version:

Issue description

at Logger.hpp set #define MS_LOG_DEV_LEVEL 3
then
cd worker
make

got error, some info below:
228 | MS_DEBUG_DEV("arrival_time_ms - first_arrival_time_ms_:%f, smoothed_delay_:%f", kv.first, kv.second);
| ^~~~~
../../../include/Logger.hpp:298:143: note: in definition of macro ‘MS_DEBUG_DEV’
298 | const int loggerWritten = std::snprintf(Logger::buffer, Logger::BufferSize, "D" MS_LOG_STR_DESC desc, MS_LOG_ARG, ##VA_ARGS);
| ^~~~~~~~~~~
../../../deps/libwebrtc/libwebrtc/modules/congestion_controller/goog_cc/trendline_estimator.cc:228:104: error: ‘struct webrtc::TrendlineEstimator::PacketTiming’ has no member named ‘second’
228 | MS_DEBUG_DEV("arrival_time_ms - first_arrival_time_ms
:%f, smoothed_delay
:%f", kv.first, kv.second);

trendline_estimator.cc
source code below:

#if MS_LOG_DEV_LEVEL == 3
for (auto& kv : delay_hist_) {
MS_DEBUG_DEV("arrival_time_ms - first_arrival_time_ms_:%f, smoothed_delay_:%f", kv.first, kv.second);
}
#endif

Thanks, fixed.