versatica / mediasoup

Cutting Edge WebRTC Video Conferencing

Home Page:https://mediasoup.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

WebRtcServer `webrtctransporthandled` event is being dispatched before Router `newtransport`

piranna opened this issue · comments

At

if (webRtcServer)
{
webRtcServer.handleWebRtcTransport(transport);
}
// Emit observer event.
this.#observer.safeEmit('newtransport', transport);
we see that WebRtcServer webrtctransporthandled event is being dispatched before Router newtransport. What's the reason of that? Wouldn't it make more sense that newtransport is being dispatched first, and later webrtctransporthandled tell us that this Transport is being handled by the WebRtcServer? If not, in its current order, we are being notified that a Transport we didn't know at all before is being handled by the WebRtcServer instance...

Makes sense. PR welcome, otherwise I'll do eventually.

PR available at #1138.

Thank you :-)