Move core.loadPlugins function into plugin package
dominikbraun opened this issue · comments
Dominik Braun commented
In core/build.go
, there's a small function called loadPlugins
. This function returns a simple map containing all plugin keys and a corresponding function that loads the plugin - i.e. it simply returns an instance.
Lines 301 to 311 in 16673b1
I have no idea why this function is inside the core
package. It should be inside the plugin
package. The best way would be to just move it into a new file plugin/plugin.go
. The function signature can remain unchanged.
Vitalii Ananichev commented
Hey @dominikbraun, I'll take this one
Vitalii Ananichev commented
@dominikbraun, could you please review PR #211