vercel / ms

Tiny millisecond conversion utility

Home Page:https://npmjs.com/ms

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

String with implicit unit return undefined

1000i100 opened this issue · comments

It's near the same than : #54
but for string like this : 9h30, 1m15

why closing this without any word ?

There is good reason to do it and there is good reason to not do it :

  • KISS (Keep It Stupid Simple) can explain not doing it
  • normalize what human use, even if it's weird can explain doing it.

Please, explain your vision about ms, it will help to contribute by pull-request or by other project with ms as dependency. It depend of your vision for ms.

Ok, from #138 and #55
I understand you're ok to merge something like this if there is a merge-request/pull-request, rebased to be up-to-date and with unit test to cover the new stuff.

If yes, i should begin with a pull-request to add a CONTRIBUTE guide-line you can link to quick explain why you close or not this kind of issue.

I closed because you said it was handled and you linked to the duplicate #54

I'll discuss with the team to decide the future of ms but for now it is mostly complete, thanks!