vercel / hyper

A terminal built on web technologies

Home Page:https://hyper.is

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

xterm includes its own hard-coded map

JJJ opened this issue · comments

  • I am on the latest Hyper.app version

  • I have searched the issues of this repo and believe that this is not a duplicate

  • OS version and name: macOS 14.3 Sonoma

  • Hyper.app version: latest canary

  • Relevant information from devtools:

DevTools failed to load source map: Could not parse content for file:///hyper/target/xterm.js.map: Unexpected end of JSON input
  • The issue is reproducible in vanilla Hyper.app: Yes

Issue

DevTools attempts to load an xterm.js.map file from the target directory.

This is because xterm.js has this at the end of it:

//# sourceMappingURL=xterm.js.map

...which makes sense from xterm's perspective, but not from Hyper's.

Uncertain when exactly this started (I think it's been a while).


Two solutions:

  • modify xterm.js to strip out the manual map
  • always (or conditionally, I suppose) manually require xterm.js.map