vercel / hyper

A terminal built on web technologies

Home Page:https://hyper.is

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

IPC Sender Verification and Electron.js Version Upgrade

masood opened this issue · comments

Summary:
Thank you for designing the Hyper Desktop Application making it open-source and available. The application does a great job of following secure practices. We list pointers of concern below that can help make the application more secure.

  1. [Verifying IPC Sender] Since the application uses custom IPC messages (e.g., child_process.exec), it will be useful to introduce a mechanism that verifies the sender of the message, event.sender. [Link]
  2. [Keeping up-to-date w/ Electron.js]: The application uses an old version of Electron.js (v20.3.6) and Chromium (v104.0.5112.124) which is vulnerable to numerous known V8 and Blink attacks. Upgrading to an even newer version will be a great idea as well [Link]

Thank you!

Platform(s) Affected:
Windows, Linux, MacOS


Mir Masood Ali, PhD student, University of Illinois at Chicago
Mohammad Ghasemisharif, PhD Candidate, University of Illinois at Chicago
Chris Kanich, Associate Professor, University of Illinois at Chicago
Jason Polakis, Associate Professor, University of Illinois at Chicago