One of Comments’s migrations failed

Question

One of Comments’s migrations failed

jsellerIPOP opened this issue 3 years ago · comments

Hey

I am getting the following error when trying to upgrade from Craft 2 to Craft 3:

Database Exception: SQLSTATE[22007]: Invalid datetime format: 1292 Incorrect datetime value: '0000-00-00 00:00:00' for column 'commentDate' at row 1
The SQL being executed was: ALTER TABLE craft_comments_comments ADD commentDate datetime(0) NOT NULL AFTER userAgent

Migration: verbb\comments\migrations\m180826_000000_add_comment_date_column

Please can you assist?

Josh Crawford · Answer 1 · Tue Jun 22 2021 15:15:45 GMT+0800 (China Standard Time)

Hmmm, so that new column should be adding the values for each comment from their dateCreated column. Can you confirm if there are any values with this as their value? That itself would be an issue for Craft 2, which handles the dateCreated column.

jsellerIPOP · Answer 2 · Tue Jun 22 2021 21:30:10 GMT+0800 (China Standard Time)

Yes there are values in the database under the dateCreated column. I can't see any rows for commentDate, not sure if it's supposed to. Any help appreciated

Josh Crawford · Answer 3 · Thu Jun 24 2021 10:08:34 GMT+0800 (China Standard Time)

So commentDate will be a new column that the migration adds, but it copies across the value from the dateCreated column. I think you might have 0000-00-00 00:00:00 as the value for some comments in the dateCreated column.

jsellerIPOP · Answer 4 · Thu Jun 24 2021 20:47:17 GMT+0800 (China Standard Time)

I have double checked and there is no reference to 0000-00-00 00:00:00 in that column. What would be the best way to get around this? Remove the content Cheers *Jonny Seller *// Co-founder & Director Web Development *iPOP Digital* www.ipopdigital.com ***@***.*** *Sign up for e-news updates* <https://ipopdigital.us9.list-manage.com/subscribe?u=e8229c921ee3bd05d260b5ceb&id=1960579327> O. 01534 734 508 1st Floor • Ingouville House • Ingouville Lane • St Helier • Jersey • JE2 4SG

…

On Thu, 24 Jun 2021 at 03:08, Josh Crawford ***@***.***> wrote: So commentDate will be a new column that the migration adds, but it copies across the value from the dateCreated column. I think you might have 0000-00-00 00:00:00 as the value for some comments in the dateCreated column. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#231 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC2SVJA76BPXHYHZ4J67ABLTUKHSXANCNFSM47BYKB2Q> .

chill0216 · Answer 5 · Thu Jun 24 2021 22:51:05 GMT+0800 (China Standard Time)

@jsellerIPOP @engram-design Having the same issue. Also, no reference to 0000-00-00 00:00:00

Josh Crawford · Answer 6 · Fri Jun 25 2021 16:10:40 GMT+0800 (China Standard Time)

Hmmm, I'll have to spin up a Craft 2 site to test this.

Josh Crawford · Answer 7 · Sun Jun 27 2021 13:51:51 GMT+0800 (China Standard Time)

Can either of you comment in your MySQL versions? I've just done 5 migrations from Craft 2 without issue. I've added a fix that might help. To get the fix early, change your verbb/comments requirement in composer.json to:

"require": {
  "verbb/comments": "dev-craft-3 as 1.8.7",
  "...": "..."
}

Then run composer update.

jsellerIPOP · Answer 8 · Mon Jun 28 2021 19:34:12 GMT+0800 (China Standard Time)

Hi Josh Thanks for your assistance with this. I have added this to composer and run the update but unfortunately, I am still experiencing the same issue. My MySQL version is 5.7.26 Many thanks, *Jonny Seller *// Co-founder & Director Web Development *iPOP Digital* www.ipopdigital.com ***@***.*** *Sign up for e-news updates* <https://ipopdigital.us9.list-manage.com/subscribe?u=e8229c921ee3bd05d260b5ceb&id=1960579327> O. 01534 734 508 1st Floor • Ingouville House • Ingouville Lane • St Helier • Jersey • JE2 4SG

…

On Sun, 27 Jun 2021 at 06:52, Josh Crawford ***@***.***> wrote: Can either of you comment in your MySQL versions? I've just done 5 migrations from Craft 2 without issue. I've added a fix that might help. To get the fix early, change your verbb/comments requirement in composer.json to: "require": { "verbb/comments": "dev-craft-3 as 1.8.7", "...": "..." } Then run composer update. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#231 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC2SVJC7LGZJ5CYOQXLZHC3TU24ABANCNFSM47BYKB2Q> .

Josh Crawford · Answer 9 · Wed Jun 30 2021 19:13:04 GMT+0800 (China Standard Time)

@jsellerIPOP I've just pushed another more direct fix for this, which might help. Running composer update again will pull the latest change.

jsellerIPOP · Answer 10 · Fri Jul 02 2021 16:39:34 GMT+0800 (China Standard Time)

Hey Josh, This is still causing the same issue. I might see if the client needs all the old comments and remove them from the table. Thanks for your help *Jonny Seller *// Co-founder & Director Web Development *iPOP Digital* www.ipopdigital.com ***@***.*** *Sign up for e-news updates* <https://ipopdigital.us9.list-manage.com/subscribe?u=e8229c921ee3bd05d260b5ceb&id=1960579327> O. 01534 734 508 1st Floor • Ingouville House • Ingouville Lane • St Helier • Jersey • JE2 4SG

…

On Wed, 30 Jun 2021 at 12:13, Josh Crawford ***@***.***> wrote: @jsellerIPOP <https://github.com/jsellerIPOP> I've just pushed another more direct fix for this, which might help. Running composer update again will pull the latest change. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#231 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC2SVJAMRU3NTTHDWFJPWLTTVL34XANCNFSM47BYKB2Q> .

Josh Crawford · Answer 11 · Fri Jul 02 2021 18:00:16 GMT+0800 (China Standard Time)

@jsellerIPOP Sorry for the issues. I just can't replicate it on my setup, otherwise I'd be able to confirm more definitively.

If you're up for it, and able to (and you're okay with it) you're welcome to send your Craft 2 database to web at verbb.io and I can see if I can replicate your issue.

Isaac Wingate · Answer 12 · Fri Oct 20 2023 13:38:16 GMT+0800 (China Standard Time)

Was this issue ever resolved? Currently facing the same issue migrating from craft2 -> 3

Josh Crawford · Answer 13 · Tue Oct 24 2023 13:08:12 GMT+0800 (China Standard Time)

@isaacwingate Happy to look into it, but we weren't able to replicate it with a number of Craft 2 installs. If you're able to, sending your database at Craft 2 to support@verbb.io would be great so we can see what state the database is in before the upgrade.