Throw a warning if intersect removes some columns
mjutras-mitre opened this issue · comments
mjutras-mitre commented
The code works and is harmless in intended case but it would be a good idea to alert the user. If they inadvertently passed in the wrong dataset or something, a warning would catch it.
Lines 78 to 81 in 2324381
Z. Richard Li commented
mboyas-mitre commented
These messages are very useful for the user, but I'm thinking that the if condition might need to be if(length(joint) < length(colnames(symps.train)))
and if(length(joint) < length(colnames(symps.test)))
, respectively? As it stands, I think it's comparing a numeric integer to a vector.
Z. Richard Li commented
22e2eed, thanks!