Mixing of types in siphash24.c
secworks opened this issue · comments
Joachim Strömbergson commented
siphash24.c contains an of #include <stdint.h>, but then typedef to:
uint64_t u64; typedef uint32_t u32; typedef uint8_t u8;
And then define the function as:
int siphash( unsigned char *out, const unsigned char *in, unsigned long long inlen, const unsigned char *k )
How about just use stdint.h defined types as is?
Jean-Philippe Aumasson commented
fixed, thanks: a81a666