Color scheme not working
anthonyquizon opened this issue · comments
Hello,
I'm probably doing something here.
I can't seem to get the repls colour scheme working.
Here is my ~/.lein/profiles.clj
{:user {:plugins [[venantius/ultra "0.4.0"]]}}
The stack trace output formatting is working so it looks like the plugin is being applied.
Using terminal.app on Mac osx
Ultra doesn't overwrite the print function - it sets the REPL to print syntax-highlighted response values. What happens if you just type {:a 1} at the REPL?
Still unhighlighted :(
Hmm, now that is weird. Assuming you're inside a particular project, could you do lein deps :tree and let me know what the output is?
If the rest of the plugin is working, you should still be able to call the colorized printer manually. What happens when you execute the following code at the REPL (you shouldn't need to do a require, Ultra should handle that for you):
(ultra.printer/cprint {:a 1})
Sure thing
lein deps :tree
➜ hello-world lein deps :tree
Possibly confusing dependencies found:
[org.clojure/tools.nrepl "0.2.10" :exclusions [org.clojure/clojure]]
overrides
[venantius/ultra "0.4.0"] -> [org.clojure/tools.nrepl "0.2.11"]
Consider using these exclusions:
[venantius/ultra "0.4.0" :exclusions [org.clojure/tools.nrepl]]
[clojure-complete "0.2.3" :exclusions [[org.clojure/clojure]]]
[org.clojure/clojure "1.7.0"]
[org.clojure/tools.nrepl "0.2.10" :exclusions [[org.clojure/clojure]]]
[venantius/ultra "0.4.0"]
[im.chit/hara.class "2.2.11"]
[im.chit/hara.class.checks "2.2.11"]
[im.chit/hara.class.inheritance "2.2.11"]
[im.chit/hara.namespace.import "2.2.11"]
[im.chit/hara.reflect "2.2.11"]
[im.chit/hara.common.checks "2.2.11"]
[im.chit/hara.common.string "2.2.11"]
[im.chit/hara.common "2.2.11"]
[im.chit/hara.common.error "2.2.11"]
[im.chit/hara.common.hash "2.2.11"]
[im.chit/hara.common.primitives "2.2.11"]
[im.chit/hara.data.map "2.2.11"]
[im.chit/hara.protocol.string "2.2.11"]
[io.aviso/pretty "0.1.18"]
[mvxcvi/puget "0.9.2"]
[fipp "0.6.2"]
[org.clojure/core.rrb-vector "0.0.11"]
[mvxcvi/arrangement "1.0.0"]
[mvxcvi/whidbey "1.1.1"]
[org.clojure/data.codec "0.1.0"]
[org.clojars.brenton/google-diff-match-patch "0.1"]
[robert/hooke "1.3.0"]
[venantius/glow "0.1.2"]
[clj-antlr "0.2.2"]
[org.antlr/antlr4-runtime "4.2.2"]
[org.abego.treelayout/org.abego.treelayout.core "1.0.1"]
[org.antlr/antlr4-annotations "4.2.2"]
[org.antlr/antlr4 "4.2.2"]
[org.antlr/ST4 "4.0.8"]
[org.antlr/antlr-runtime "3.5.2"]
[instaparse "1.4.1"]
(ultra.printer/cprint {:a 1})
The cprint output suggests to me that this is simply a matter of Terminal configuration rather than an Ultra issue. Could you show me what your Terminal.app's "Profiles" window looks like (in Preferences)?
Yeah I had that thought - but I couldn't find a setting that would cause this issue.
I'm using zsh if that means anything
I suspect zsh may be the issue here; some quick Googling suggests that zsh has its own escape codes for colors and that traditional ANSI escape codes for coloring may not work. If that's true, then the fix should be relatively simple - just shell out to the console to figure out what shell Leiningen is being executed under and configure escape codes as necessary.
For what it's worth, I was able to get highlighting working in zsh by adding :color-scheme to my profiles.clj explicitly as described in #48. Might be worth a shot!
Oh balls. I should really fix that bug :/
I wrote a small patch this morning that seems to fix it, if you'd like a PR. It's nothing fancy, it replaces the nils in the default color scheme with the values from Solarized Dark. It would close a few issues while you decide whether to continue supporting custom color schemes though. :)
Sure, why not? Can't hurt to look at it, at the very least :)
Cool, I've opened #51. Thanks for having a look!