veloren / veloren

An open world, open source voxel RPG inspired by Dwarf Fortress and Cube World. This repository is a mirror. Please submit all PRs and issues on our GitLab page.

Home Page:https://www.veloren.net

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Incorrect getter names for Entity struct

Zestylimez opened this issue · comments

https://github.com/veloren/game/blob/master/region/src/entity.rs#L18

The first three methods do not follow the naming convention for getters and setters. I suggest renaming the methods to get_pos, get_movdir, and get_lookdir.