veged / xjst

Extensible JavaScript Transformations

Home Page:http://veged.github.com/xjst/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

xjst@0.7.18 broke bemtree in js-syntax

blond opened this issue · comments

Hi!

enb-bemxjst use bem-core@v1, in turn bem-core@v1 use bem-xjst, and bem-xjst use xjst.

When xjst was <= 0.7.17 test from enb-bemxjst builded correctly.

You can see this error: https://travis-ci.org/enb-make/enb-bemxjst/jobs/10452247

Maximum call stack size exceeded

Perhaps this error occurs through my code: https://github.com/enb-make/enb-bemxjst/blob/master/test/fixtures/bemtree/blocks/i-start/i-start.bemtree

The problem is not in i-start block, the problem appears to be here: https://github.com/enb-make/enb-bemxjst/blob/master/test/fixtures/bemtree/blocks/page/page.bemtree#L13 .

I'm trying to figure out the best way to solve it...

In order to fix, you need to write: def().match(!this.ctx.title).match(!this.ctx.head)(function() {...}) here https://github.com/enb-make/enb-bemxjst/blob/master/test/fixtures/bemtree/blocks/page/page.bemtree#L3 . Or something similar to it, otherwise it'll get to this template infinite amount of times.

Thanks!