vedhavyas / cuckoo-filter

Cuckoo Filter: Practically better than bloom filter

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Encode is not thread safe

VirrageS opened this issue · comments

Shallow copy is not enough when doing encode. See that here: https://github.com/vedhavyas/cuckoo-filter/blob/master/cuckoo.go#L419 bucket array is only shallow copied. This means if we start encoding and do some delete keys concurrently we might have inconsistencies.

Apologies for late reply. Should be fixed with the above PR and make a release after.