[Bug]: winget-releaser creates incorrect mapping between Architecture and InstallerUrl

Question

[Bug]: winget-releaser creates incorrect mapping between Architecture and InstallerUrl

twpayne opened this issue a year ago · comments

Tom Payne commented a year ago

Is there an existing issue for this?

I have searched the existing issues

What happened?

See https://github.com/microsoft/winget-pkgs/pull/110014/files.

Short version:

PR automatically created by winget-releaser.
The PR is clearly incorrect: in the Installers section, there are four different Architectures (x64, x86, arm, arm64) and yet all four InstallerUrls point at the same amd64 zip file with the same SHA256 hash.

The winget-releaser action used to create this PR is:
https://github.com/twpayne/chezmoi/blob/30f5995ec56381c27cfa238dc48fe8024eae0f29/.github/workflows/winget.yml

I would expect winget-releaser to use the architecture-appropriate zip file for each Architecture. All zip files are available as release assets in https://github.com/twpayne/chezmoi/releases/tag/v2.34.2.

Please let me know how I can help debug/resolve this issue.

Vedant · Answer 1 · Tue Jun 20 2023 11:26:19 GMT+0800 (China Standard Time)

cc @russellbanks

Timothy Johnson · Answer 2 · Wed Jun 21 2023 06:56:48 GMT+0800 (China Standard Time)

I have the same issue with this PR automatically created by winget-releaser. It selected the ARM64 installer for all architectures.

The GitHub workflow is here: https://github.com/t1m0thyj/WinDynamicDesktop/blob/main/.github/workflows/release-winget.yml

There is a separate installer for each architecture:

Vedant · Answer 3 · Wed Jun 21 2023 07:36:04 GMT+0800 (China Standard Time)

I will update the action to use the previous release of Komac until the bug is fixed over there. (russellbanks/Komac#215)

Vedant · Answer 4 · Wed Jun 21 2023 07:47:07 GMT+0800 (China Standard Time)

I apologize for the inconvenience caused. Could you please try to re-run the workflow jobs to create a fresh PR? Hopefully, this should create the correct PRs.

Christian Brabandt · Answer 5 · Thu Jun 22 2023 17:03:21 GMT+0800 (China Standard Time)

Same thing happened to vim last week https://github.com/vim/vim-win32-installer/actions/runs/5273078475/jobs/9536084416

Unfortunately now new runs keep failing with "The number of unique installer urls is greater than the number of previous manifest urls", not sure if this is related or not :/ russellbanks/Komac#224

Vedant · Answer 6 · Thu Jun 22 2023 17:27:28 GMT+0800 (China Standard Time)

It will be automatically fixed once microsoft/winget-pkgs#110397 is merged.

Tom Payne · Answer 7 · Tue Jul 04 2023 14:51:12 GMT+0800 (China Standard Time)

There has been no new version of winget-releaser since this was fixed, so users using the latest major of winget-releaser are still experiencing this bug.

Refs microsoft/winget-pkgs#111215.

Russell Banks · Answer 8 · Tue Jul 04 2023 16:09:17 GMT+0800 (China Standard Time)

There has been no new version of winget-releaser since this was fixed, so users using the latest major of winget-releaser are still experiencing this bug.

@twpayne, I believe this was due to a regex bug in 1.8.0 of Komac. This is fixed now that WinGet Releaser has updated to 1.8.1. Here was my test:

java -jar Komac-1.8.1-all.jar update --id 'twpayne.chezmoi' --version 2.34.3 --urls 'https://github.com/twpayne/chezmoi/releases/download/v2.34.3/chezmoi_2.34.3_windows_arm64.zip,https://github.com/twpayne/chezmoi/releases/download/v2.34.3/chezmoi_2.34.3_windows_i386.zip,https://github.com/twpayne/chezmoi/releases/download/v2.34.3/chezmoi_2.34.3_windows_arm.zip,https://github.com/twpayne/chezmoi/releases/download/v2.34.3/chezmoi_2.34.3_windows_amd64.zip'

# Created with Komac v1.8.1
# yaml-language-server: $schema=https://aka.ms/winget-manifest.installer.1.4.0.schema.json

PackageIdentifier: twpayne.chezmoi
PackageVersion: 2.34.3
InstallerType: zip
NestedInstallerType: portable
NestedInstallerFiles:
- RelativeFilePath: chezmoi.exe
  PortableCommandAlias: chezmoi
Installers:
- Architecture: x86
  InstallerUrl: https://github.com/twpayne/chezmoi/releases/download/v2.34.3/chezmoi_2.34.3_windows_i386.zip
  InstallerSha256: 03FDC9413DA849D03A386DF9F02254FE48C1EEF712148F375A2C4B0D21A962FD
- Architecture: x64
  InstallerUrl: https://github.com/twpayne/chezmoi/releases/download/v2.34.3/chezmoi_2.34.3_windows_amd64.zip
  InstallerSha256: 8DFC6B2F46FA86B00A20B8C1C86707813317660165D72A29263CB05A652BEACC
- Architecture: arm
  InstallerUrl: https://github.com/twpayne/chezmoi/releases/download/v2.34.3/chezmoi_2.34.3_windows_arm.zip
  InstallerSha256: 4D70FE69162FF5C76C4A74AE9AA3C6B1F07BD80AB25C2F91326E7721FA990704
- Architecture: arm64
  InstallerUrl: https://github.com/twpayne/chezmoi/releases/download/v2.34.3/chezmoi_2.34.3_windows_arm64.zip
  InstallerSha256: 1F888B8F731AD14D987B6B7A0B7C0313E1E263C3C0741FD32E22F468C20DFAFD
ManifestType: installer
ManifestVersion: 1.4.0

Tom Payne · Answer 9 · Tue Jul 04 2023 16:20:37 GMT+0800 (China Standard Time)

This is confusing:

The latest release of Winget Releaser is v2, which was released on February 12 and obviously does not contain this bug fix from June: https://github.com/vedantmgoyal2009/winget-releaser/releases

However, it looks like the v2 tag itself was moved recently: https://github.com/vedantmgoyal2009/winget-releaser/tags

If Winget Releaser is moving tags around then it's likely to confuse a lot of systems and people. Winget Releaser should not move tags and should use semantic versioning instead.

Russell Banks · Answer 10 · Tue Jul 04 2023 16:37:40 GMT+0800 (China Standard Time)

@vedantmgoyal2009

Christian Brabandt · Answer 11 · Wed Jul 12 2023 15:00:56 GMT+0800 (China Standard Time)

@vedantmgoyal2009 was this supposed to be fixed? It still happened to the Vim Deployment yesterday: microsoft/winget-pkgs#111716

Tom Payne · Answer 12 · Wed Jul 12 2023 15:39:52 GMT+0800 (China Standard Time)

@chrisbra This is apparently fixed but there has been no new release with the fix yet. You could pin your use of the GitHub action to a specific commit to get it, but v2 of winget-releaser is still broken.

Christian Brabandt · Answer 13 · Wed Jul 12 2023 16:02:22 GMT+0800 (China Standard Time)

so instead of using @v2 using @f5fe57eeed3b1d0ece9116be65c80c5c53354db9 should fix it?

Tom Payne · Answer 14 · Wed Jul 12 2023 16:06:45 GMT+0800 (China Standard Time)

Yes, exactly.

Christian Brabandt · Answer 15 · Wed Jul 12 2023 16:10:59 GMT+0800 (China Standard Time)

thanks, will do

Russell Banks · Answer 16 · Wed Jul 12 2023 18:27:46 GMT+0800 (China Standard Time)

@chrisbra I've spent some time looking into this. The URL https://github.com/vim/vim-win32-installer/releases/download/v9.0.1677/gvim_9.0.1677_x64.exe was being identified as an x86 installer because of the win32 in vim-win32-installer. I've created a fix to use the architecture most towards the end of the URL, as that's where they usually are.

Christian Brabandt · Answer 17 · Wed Jul 12 2023 18:51:52 GMT+0800 (China Standard Time)

thank you! But that also means I need to await an update here from @vedantmgoyal2009 right?

Russell Banks · Answer 18 · Wed Jul 12 2023 19:02:48 GMT+0800 (China Standard Time)

thank you! But that also means I need to await an update here from @vedantmgoyal2009 right?

WinGet Releaser uses the latest version of Komac, so I just need to make a release. I've created #187 as a feature request for scenarios like this where you might want to temporarily use the nightly release or a slightly older version if there's an issue affecting your package.

Vedant · Answer 19 · Wed Sep 13 2023 22:05:26 GMT+0800 (China Standard Time)

@all-contributors please add @twpayne for bug

allcontributors · Answer 20 · Wed Sep 13 2023 22:05:36 GMT+0800 (China Standard Time)

@vedantmgoyal2009

I've put up a pull request to add @twpayne! 🎉