Giters

vbabiy / djangorestframework-camel-case

Camel case JSON support for Django REST framework.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Version 1.0.3 in PyPI differs from version 1.0.3 on GitHub

robrichter opened this issue · comments

commented

When you install version 1.0.3 from PyPI by pip install djangorestframework-camel-case you get completely different code than on GitHub.

Few examples of differencies:
render module is missing class CamelCaseBrowsableAPIRenderer
parser module contains: from rest_framework.parsers import six, FormParser

commented

Seeing the same issue here.

commented

Same here.

commented

Same here. Not able to import renderers as a result.

commented

Bump the version, publish on PyPI!

commented

Same issue. Is there a working version I can use until this one is updated?

commented

@robrichter @Racum @jastee07 @HymanZHAN @alexandremjacques

Seems like the master branch is indeed working fine even though the pypi version doesn't work.

What I did was instead just install the package directly from github using pipenv. This can also be done with pip.

Basically I just ran the following command:

pipenv install git+https://github.com/vbabiy/djangorestframework-camel-case.git@master#egg=djangorestframework-camel-case

Not that it adds any information to my solution above or anything, but I wrote an article about it on my blog if anyone is bored and wants to check it out:
https://remotedevdaily.com/how-to-install-packages-from-github-with-pip-and-pipenv/

commented

As you can see here, #65 (comment) @vbabiy said that he will review some other PRs before pushing a new version of PyPI. I'm sure it will be soon 😉

We downgraded drf to v3.9.4 for the moment

commented

I just did a fresh install, latest DRF, latest DRF-camel-case from pypi and I'm having this issue:

ImportError: cannot import name 'six' from 'rest_framework.parsers'

I think it's important for plugins like this to work with the latest release version of the software they support. New users of DRF-camel-case for the past month have been getting this error and reasonably concluding that this isn't a supported project. I think that's bad for the project and for our community here.

commented

I just did a fresh install, latest DRF, latest DRF-camel-case from pypi and I'm having this issue:

ImportError: cannot import name 'six' from 'rest_framework.parsers'

I think it's important for plugins like this to work with the latest release version of the software they support. New users of DRF-camel-case for the past month have been getting this error and reasonably concluding that this isn't a supported project. I think that's bad for the project and for our community here.

There is a second version someone made until this one is supported again: https://pypi.org/project/django-rest-framework-camel-case/

commented

@vbabiy in case you're looking for maintainers I would be happy to help. Also could be a good project to integrate with jazzband.

commented

Hello everyone,

I use this dependency on several of my projects, therefore I decided to fork it push it PyPI:

https://github.com/canassa/djangorestframework-camel-case

You can install it with:

pip install djangorestframework-camel-case-2

It's a drop-in replacement. Feel free to use it!

commented

I use this dependency on several of my projects, therefore I decided to fork it push it PyPI:

I think a better solution would be to do a pip install with a commit, rather releasing a new package to PyPi.

pip install git+https://github.com/vbabiy/djangorestframework-camel-case.git@39ae6bbde19d3fadc5b60505395c51f44b22a069

Also, I get that you've put your information in the setup.py with your approach, but changing the init to you does not make sense to me.

commented

@JonasKs I was doing git+https install, but the problem is that it's a slower than a regular install from PyPI and I don't think it's cacheable by pip. I am also planning on adding extra features to it and merge some of the issues that are already open in here, so that's why I pushed it PyPI

Good point on the init, I am not very sure on how to proceed with that on forks. I don't want to give the impression that I am trying to steal anyone work 😉 but on the other hand I want to make sure that people get in contact with me and not vbabiy regarding issues and/or question about my fork.

commented

If @canassa is willing to start maintaining a branch of this I'd use it. If at a later date @vbabiy is available again, they can work out merging back, sharing maintenance, whatever.