Add Typescript typings

Question

Add Typescript typings

curtisy1 opened this issue 5 years ago · comments

Would you be willing to add typings for Typescript to this project? If you don't mind, I'll try working on getting these to work while integrating vasern in my project.

Hieu Nguyen (Jack) · Answer 1 · Wed Feb 06 2019 08:54:46 GMT+0800 (China Standard Time)

@curtisy1 Hi Alex, I do plan to add Typescript to this project. Though I won't be able to do it at this moment as I am focusing on developing its server.

In case you want to add Typescript into the project, I'd really appriciate it.
Let me know and be willing to help.

Alex · Answer 2 · Thu Feb 07 2019 03:14:53 GMT+0800 (China Standard Time)

Alright, I'll start working on this today and submit a WIP pull request once I have some typings going so you can make comments on eventual coding guidelines I should adhere to

Hieu Nguyen (Jack) · Answer 3 · Thu Feb 07 2019 05:26:06 GMT+0800 (China Standard Time)

Great @curtisy1, thank you! Just a note, all the JavaScript code are in vasern/vasern/src.

Let me know if you need anything to get started

Hieu Nguyen (Jack) · Answer 4 · Wed Feb 13 2019 08:23:23 GMT+0800 (China Standard Time)

Hi @curtisy1, in case you need any help, please let me know. Or send me a message through our slack channel. I'm on Slack pretty often.

Cheers!

Alex · Answer 5 · Fri Feb 15 2019 23:54:26 GMT+0800 (China Standard Time)

Sure thing! I'm almost done with the typings. Just need to iron out some conditions that I'm not quite sure about by testing each feature in an example database. I'll definitely contact you through Slack when I have questions.

Hieu Nguyen (Jack) · Answer 6 · Sat Feb 16 2019 13:29:09 GMT+0800 (China Standard Time)

Nice works @curtisy1. I have also added you as our contributors.

Since it is added to the repo, I'll close this issue and feel free to open again or create a new issue

Thanks a lot!